CLI getIpfs uses wrong args object

[hugomrdias]

• Version:
• Platform:
• Subsystem:

Type: Bug

Severity: High

Description:

this line
https://github.com/ipfs/js-ipfs/blob/master/src/cli/bin.js#L48
passes an argv obj that wasn't created with our yargs config

This makes cmds like ipfs add --silent ./path/file to instantiate IPFS with { silent : './path/file' }

Right now master doesn't fail because silent wasn't added to the validation yet, still this behaviour should be fixed.

Steps to reproduce the error:

[grassias]

If we changed the line https://github.com/ipfs/js-ipfs/blob/master/src/cli/bin.js#L48
into: const getIpfs = utils.singleton(cb => utils.getIPFS(cli.argv, cb))?
That'll do it?

[alanshaw]

Sadly no, argv is an accessor that causes a handler for the command to be invoked. At the point where getIpfs is called we're already in a handler so we need a new yargs which doesn't have the commands handlers. All we're missing is the ability to parse the global options (--silent and --pass).

I think we just need a helper function to create a new yargs with the global options that we can use and assign to cli as well as use in getIpfs.

[hugomrdias]

made some suggestions in the #1955 PR

[alanshaw]

Thanks again @grassias ❤️