Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

wrapWithDirectory test fails #1328

Closed
vmx opened this issue Apr 27, 2018 · 6 comments
Closed

wrapWithDirectory test fails #1328

vmx opened this issue Apr 27, 2018 · 6 comments
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP

Comments

@vmx
Copy link
Member

vmx commented Apr 27, 2018

The test interface-ipfs-core tests .files .add wrapWithDirectory on master fails. To reproduce the issue, simply run npx mocha --exit test/core/interface/files.js from within the js-ipfs root directory.

I make this a P0 as it prevent CI from passing.
@vmx vmx added kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP status/blocked Unable to be worked further until needs are met labels Apr 27, 2018
@vmx
Copy link
Member Author

vmx commented Apr 27, 2018

It seems that the test is correct as https://github.com/ipfs/js-ipfs-api/pull/750/files#diff-438d3282bfe7cdd71c3818dfce192cb6R167 also checks for two elements in the result.

@victorb
Copy link
Member

victorb commented Apr 27, 2018

Test that broke ipfs/js-ipfs#master was added here: ipfs-inactive/interface-js-ipfs-core#251 and interface-ipfs-core version 0.60.1 was released without testing with js-ipfs first

@victorb
Copy link
Member

victorb commented Apr 27, 2018

Agree that tests seems correct, but js-ipfs doesn't have the "wrap with directory" functionality yet

@victorb
Copy link
Member

victorb commented Apr 27, 2018

There is a pending PR here though: #1290

@victorb
Copy link
Member

victorb commented Apr 27, 2018 •
edited
Loading

@diasdavid this PR resolves this issue and makes CI green, could you please review and merge? #1329

@daviddias daviddias removed the status/blocked Unable to be worked further until needs are met label Apr 30, 2018
@daviddias
Copy link
Member

Thank you for fixing this in a timely manner, @victorbjelkholm :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vmx @victorb @daviddias