Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Node crashes with "Missing peerId" after a few minutes #1221

Closed
victorb opened this issue Feb 16, 2018 · 9 comments · Fixed by libp2p/js-libp2p-secio#101 or #1285
Closed

Node crashes with "Missing peerId" after a few minutes #1221

victorb opened this issue Feb 16, 2018 · 9 comments · Fixed by libp2p/js-libp2p-secio#101 or #1285
Assignees
Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP

Comments

@victorb
Copy link
Member

victorb commented Feb 16, 2018

  • Version: 0.27.7
  • Platform: x86_64 GNU/Linux
  • Subsystem:

Type:

Bug

Description:

Node crashes after ~5 minutes (varies though) with error AssertionError [ERR_ASSERTION]: Missing peerId. Use Peer.create(cb) to create one

Full logs are here: https://gist.github.com/VictorBjelkholm/0e7819b3a19caab7dbfc3172ab222184

Steps to reproduce the error:

  • git clone https://github.com/VictorBjelkholm/js-ipfs-docker.git
  • cd js-ipfs-docker
  • yarn
  • node index.js
  • Wait until it crashes
@victorb victorb added the kind/bug A bug in existing code (including security flaws) label Feb 16, 2018
@daviddias daviddias added exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked labels Feb 16, 2018
@kevinsimper
Copy link

I have seen the same thing

@daviddias
Copy link
Member

Pinpointed it at MetaMask/mesh-testing#3 (comment)

@daviddias daviddias added P0 Critical: Tackled by core team ASAP and removed P2 Medium: Good to have, but can wait until someone steps up labels Mar 21, 2018
@jacobheun jacobheun self-assigned this Mar 27, 2018
@jacobheun
Copy link
Contributor

I want to get some tests added to validate and maintain integrity, but I believe this issue was fixed by the connection cascading fix in libp2p/js-libp2p-secio#98. This was included in the js-ipfs 0.28.0 release.

@jacobheun
Copy link
Contributor

jacobheun commented Mar 28, 2018

My initial thought was wrong, I found the issue causing the crash.

libp2p/js-libp2p-secio#101 resolves this

Once that's merged and added to a release, I will make a PR here to bump the secio version.

@jacobheun jacobheun added status/in-progress In progress and removed status/ready Ready to be worked labels Mar 28, 2018
@ghost ghost removed the status/in-progress In progress label Mar 28, 2018
@jacobheun jacobheun reopened this Mar 28, 2018
@jacobheun jacobheun added the status/in-progress In progress label Mar 28, 2018
@jacobheun
Copy link
Contributor

This was accidentally closed. I'll have a PR shortly to update versioning to properly fix this.

@shessenauer
Copy link

I am still getting this issue while using ipfs-js 0.28.2 and am unable to be discoverable and have peers. Anyone else having this issue as well?

@kevinsimper
Copy link

@shessenauer Are you using webrtc or websocket as discovery? Webrtc is still resource heavy and bit new still compared to the more stable websocket.

@shessenauer
Copy link

@kevinsimper currently using websocket as discovery

@kevinsimper
Copy link

@shessenauer Then you need to post an example of what is not working :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP
Projects
None yet
5 participants