feat: add glob-source from js-ipfs so it can be shared with the http client #9
Conversation
achingbrain
force-pushed
the
add-glob-source
branch
3 times, most recently
from
4e4fcf0 to
ab8edd2
Compare
src/files/glob-source.js
Outdated
| * @param {Boolean} [options.followSymlinks] follow symlinks | ||
| * @yields {Object} File objects in the form `{ path: String, content: AsyncIterator<Buffer> }` | ||
| */ | ||
| module.exports = async function * globSource (...args) { |
There was a problem hiding this comment.
can't the arguments be function(Array<string> paths, Object options) ? instead of multiple paths as arguments?
There was a problem hiding this comment.
It's just been ported as-is from js-ipfs
Done |
|
ready to merge ? |
|
I'm starting to think you're right about the function signature. Having an iterable as the first argument would let us stream stuff into this function. |
|
Who would even build a stupid API like that? Oh...
|
|
Merge and release please 🙏 |
|
can you fix the conflicts please? |
The business of turning a path and pattern into an iterator of files is duplicated between js-ipfs and js-ipfs-http-client so moving it here to aid deduplication.
Fix typo Co-Authored-By: Hugo Dias <hugomrdias@gmail.com>
achingbrain
force-pushed
the
add-glob-source
branch
from
3fe3f26 to
6d976fa
Compare
I had this exact experience while looking at pointless mfs tests that don't assert anything in Who wrote this garbage? Oh, it was me. |
The business of turning a path and pattern into an iterator of files is duplicated between
js-ipfsandjs-ipfs-http-clientso moving it here to aid deduplication.