fix: convert car stream to iterable #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2022
### [2.1.1](v2.1.0...v2.1.1) (2022-04-13) ### Bug Fixes * convert car stream to iterable ([#317](#317)) ([87a83d0](87a83d0))
|
🎉 This PR is included in version 2.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is an extension to the previous PR to support CAR import.
The in-memory js-ipfs requires the CAR file (stream) to be an 'iterable' object. This means we need to convert the ReadableStream to AsyncIterable.
Instead of showing
Explorebutton when CAR import is chosen, we instead should just consume the CAR directly and import the dag file as soon as the user uploads the file.Related to
#313
ipld/explore.ipld.io#82