Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): more robust e2e #1523

Merged
merged 1 commit into from
Jun 11, 2020
Merged

fix(ci): more robust e2e #1523

merged 1 commit into from
Jun 11, 2020

Conversation

lidel
Copy link
Member

@lidel lidel commented Jun 11, 2020

This PR takes #1518 even further: ensures we wait as long as needed for a full page load, all necessary DOM elements, and set globaltimeout of 30s for jest and expect libs used in e2e tests.

If CI is green, I am merging this so js-ipfs and go-ipfs take advantage of this.

this ensures we wait as long as needed for a full page load,
all necessary DOM elements, and set globaltimeout of 30s
for jest and expect libs used in e2e tests
@lidel lidel marked this pull request as ready for review June 11, 2020 00:15
@lidel lidel merged commit 1c5e140 into master Jun 11, 2020
@lidel lidel deleted the fix/hardening-e2e branch June 11, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant