Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve shell component ux #1487

Merged
merged 1 commit into from
May 7, 2020

Conversation

rafaelramalho19
Copy link
Contributor

So, this is a nifty pick, but it was bugging me out having to remove the $ sign every time I copied a shell command. So I made it not selectable 😄

I also made the shell component responsive, which helped in some viewports:

image

Here's the interaction:
Hnet-image (1)

Copy link
Contributor

@jessicaschilling jessicaschilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both these things have bugged me too. Thanks for fixing!

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty sweet!

Can we make it even better by making a click select entire line instead of a single word?
(see force-select class from ipfs-css)

@rafaelramalho19
Copy link
Contributor Author

@lidel Couldn't that bother the user if he only wanted to select a certain portion of the command? Maybe a better alternative is to add a copy button? 🤔

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm.. good point.

Creating UI/component for copying is something may want to tackle in separate PR.

Feel free to squash and merge this - @rafaelramalho19 should have permissions to do so.

@rafaelramalho19 rafaelramalho19 merged commit eac930e into master May 7, 2020
@rafaelramalho19 rafaelramalho19 deleted the fix/make-shell-prefix-not-selectable branch May 7, 2020 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants