Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drag and drop of files is broken on Mac #1367

Closed
autonome opened this issue Dec 20, 2019 · 2 comments
Closed

drag and drop of files is broken on Mac #1367

autonome opened this issue Dec 20, 2019 · 2 comments
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up

Comments

@autonome
Copy link

Describe the bug
Dropping a file on the Files page of webui when opened in IPFS Desktop fails with an error.

To Reproduce
Steps to reproduce the behavior:

  1. Open the Files screen from the IPFS Desktop menubar application
  2. Drag a file from Finder and drop it on the screen
  3. See error in screenshot

Expected behavior
The file is added to IPFS and shows up in the Files list

Screenshots

Screen Shot 2019-12-20 at 7 08 52 AM

Desktop (please complete the following information):

  • OS: Mac OS 10.14.6 (18G1012)
  • Browser: Chrome (Electron)
  • IPFS Desktop: 0.10.2

Additional context

Console log:

TypeError: Cannot read property 'startsWith' of undefined
at D (main.4e777785.chunk.js:1)
at main.4e777785.chunk.js:1
at l (5.efc4ede5.chunk.js:1)
at Generator._invoke (5.efc4ede5.chunk.js:1)
at Generator.S.forEach.e. [as next] (5.efc4ede5.chunk.js:1)
at n (5.efc4ede5.chunk.js:1)
at u (5.efc4ede5.chunk.js:1)

@lidel
Copy link
Member

lidel commented Dec 20, 2019

@autonome just to confirm it is limited to Electron runtime on Mac: do you get the same error when opening Web UI via IPFS Companion's browser action menu in regular Chromium-based browser? (Google Chrome or Brave)

@autonome
Copy link
Author

Aha, reproduced on Chrome Canary.

@lidel lidel added kind/bug A bug in existing code (including security flaws) exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up labels Jan 7, 2020
@lidel lidel changed the title drag and drop of files is broken on Mac with IPFS Desktop drag and drop of files is broken on Mac Apr 24, 2020
@lidel lidel closed this as completed in 2a4f920 Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Development

No branches or pull requests

2 participants