From 068f4e64c1a5d7592918425a8c374ddf5c69eeb1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Criado-P=C3=A9rez?= Date: Wed, 20 Sep 2023 01:12:41 +0200 Subject: [PATCH 1/2] Corrections on md and ts files --- DEVELOPER-NOTES.md | 4 ++-- README.md | 2 +- types/countly-sdk-nodejs.d.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/DEVELOPER-NOTES.md b/DEVELOPER-NOTES.md index 29dc3e6db..c35285f6f 100644 --- a/DEVELOPER-NOTES.md +++ b/DEVELOPER-NOTES.md @@ -14,11 +14,11 @@ Manually test a few things that don't transfer well to automated testing: 1. **Mac & Windows (both must to be checked):** Confirm that drag-and-drop file import works: - Open _Files_ screen - Drag file(s) into it (PDF, images, or videos) - - Confirm file(s) import was succesful by clicking on newly imported file to preview + - Confirm file(s) import was successful by clicking on newly imported file to preview 2. **Mac & Windows (one check is sufficient):** Confirm that import via _Import_ button works: - Open _Files_ screen - Click on _Import_ button and select files(s) (directory, or standalone PDF, images, or videos) - - Confirm file(s) import was succesful by clicking on newly imported file to preview + - Confirm file(s) import was successful by clicking on newly imported file to preview 3. **Mac only:** Drag/drop onto menubar icon behaves as expected when dragging one file, several files, and a combination of files/folders: - File(s) import correctly - Correct link is copied to clipboard diff --git a/README.md b/README.md index 7f910695c..dac9edc1f 100644 --- a/README.md +++ b/README.md @@ -225,7 +225,7 @@ You can open these files from the IPFS logo menu by selecting `Open Logs Directo ### How does IPFS Desktop select the IPFS repo location? -IPFS Desktop uses [ipfsd-ctl](https://github.com/ipfs/js-ipfsd-ctl), which, by default, checks the `IPFS_PATH` environment variable. If that isn't set, it falls back to `$HOME/.ipfs`. As soon as the first run has succeded, repository location info is saved in the configuration file, which becomes the source of truth. +IPFS Desktop uses [ipfsd-ctl](https://github.com/ipfs/js-ipfsd-ctl), which, by default, checks the `IPFS_PATH` environment variable. If that isn't set, it falls back to `$HOME/.ipfs`. As soon as the first run has succeeded, repository location info is saved in the configuration file, which becomes the source of truth. To open your repo directory from the IPFS logo menu, select `Open Repository Directory` from the `Advanced` submenu. diff --git a/types/countly-sdk-nodejs.d.ts b/types/countly-sdk-nodejs.d.ts index d9e353501..986ed0303 100644 --- a/types/countly-sdk-nodejs.d.ts +++ b/types/countly-sdk-nodejs.d.ts @@ -146,7 +146,7 @@ declare module 'countly-sdk-nodejs' { * @description * This can set the maximum number of characters that is allowed per stack trace line. This also limits the crash message length. * - * @defualt 200 chars. Lines that exceed this limit will be truncated. + * @default 200 chars. Lines that exceed this limit will be truncated. */ max_stack_trace_line_length?: number, ) => void From be1fd41d99c21c19f3440f4bf94b4c03df54eb74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20Criado-P=C3=A9rez?= Date: Wed, 20 Sep 2023 01:13:31 +0200 Subject: [PATCH 2/2] Corrections on javascript files --- src/argv-files-handler.js | 2 +- src/auto-updater/index.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/argv-files-handler.js b/src/argv-files-handler.js index e1bba3154..93ab78a97 100644 --- a/src/argv-files-handler.js +++ b/src/argv-files-handler.js @@ -26,7 +26,7 @@ async function argvHandler (argv) { } module.exports = async function () { - // Checks current proccess + // Checks current process await argvHandler(process.argv) } diff --git a/src/auto-updater/index.js b/src/auto-updater/index.js index 20f35ffe6..053b92d92 100644 --- a/src/auto-updater/index.js +++ b/src/auto-updater/index.js @@ -128,7 +128,7 @@ function setup () { } if (feedback) { feedback = false - // when in instant feedback mode, show dialog immediatelly + // when in instant feedback mode, show dialog immediately feedbackDialog() } else { // show unobtrusive notification + dialog on click