Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support experimental cohosting #1171

Closed
wants to merge 3 commits into from
Closed

feat: support experimental cohosting #1171

wants to merge 3 commits into from

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Oct 5, 2019 •
edited
Loading

Implements the initial spec of cohosting.

See https://github.com/ipfs-shipyard/cohosting.

This PR requires:

- ipfs-shipyard/ipfs-cohost#5

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

@hacdias hacdias requested a review from lidel October 5, 2019 18:25
@hacdias

This comment has been minimized.

Sign in to view
@hacdias hacdias mentioned this pull request Oct 5, 2019
Merged
@hacdias

This comment has been minimized.

Sign in to view
@hacdias
Copy link
Member Author

hacdias commented Oct 6, 2019

@lidel perhaps this would also be an easy way to apply the syncing part on IPFS Companion.

@lidel
Copy link
Member

lidel commented Oct 7, 2019 •
edited
Loading

Yes, I like the idea of reusing ipfs-cohost for sync/add/remove in ipfs-companion.
Let's wait for ipfs-shipyard/ipfs-cohost#4 + NPM.

@hacdias
feat: support experimental cohosting
a6d567a 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
fix: log error
75bdf75 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
feat: use cohost from ipfs-cohost
30774af 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Copy link
Member Author

hacdias commented Nov 6, 2019

Pinging @lidel

@lidel
Copy link
Member

lidel commented Nov 7, 2019 •
edited
Loading

As agreed during last GUI/Browsers Weekly Call, let's pause this until 2020 Q1.
I don't think we should merge this without solving ipfs-shipyard/ipfs-cohost#6 first.
(We have other priorities in Q4 (#1164), need to pick our battles :))

@lidel lidel added the status/blocked Unable to be worked further until needs are met label Nov 7, 2019
@hacdias hacdias marked this pull request as draft April 17, 2020 09:42
@hacdias hacdias removed the request for review from lidel April 17, 2020 09:42
@bertrandfalguiere
Copy link
Contributor

Will this feature be revived some day?

@lidel
Copy link
Member

lidel commented Oct 7, 2020

Something like this will land, but additional UX work is needed.
We need a clear user flow where act of pinning a "website" or "page" via browser extension (ipfs/ipfs-companion#888) provides user with control over used storage (lazy vs full pin).

We won't be looking at this problem space until ipfs/ipfs-gui#91 lands – I'm closing this for now.

@lidel lidel closed this Oct 7, 2020
@hacdias hacdias deleted the feat/cohosting branch September 2, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status/blocked Unable to be worked further until needs are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hacdias @lidel @bertrandfalguiere