Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace pinning with import to mfs #997

Merged
merged 3 commits into from
May 10, 2021
Merged

feat: replace pinning with import to mfs #997

merged 3 commits into from
May 10, 2021

Conversation

lidel
Copy link
Member

@lidel lidel commented May 7, 2021

This PR changes the way IPFS content is kept around.

  • Instead of using low level pins we copy the item to MFS, unifying experience to match recent changes in ipfs-webui v2.12 and ipfs-desktop v0.15.0.
  • This also removed page-action, because it was Firefox-specific feature and made maintenance and testing more difficult (now we have same UX in all browsers).

Closes #742
Closes #888
Closes ipfs/ipfs-gui#91

This changes the way IPFS content is kept around.
Instead of using low level pins we copy the item to MFS,
unifying experience to match recent changes in ipfs-webui v2.12
and ipfs-desktop v0.15.0

This also removed page-action, because it was Firefox-specific feature
and made maintenance and testing more difficult
(now we have same UX in all browsers).

Closes #742
Closes #888
Closes ipfs/ipfs-gui#91
Comment on lines 86 to 91
"panel_importCurrentIpfsAddress": {
"message": "Import to Files at My Node",
"description": "A menu item in Browser Action pop-up (panel_importCurrentIpfsAddress)"
},
"panel_pinCurrentIpfsAddressTooltip": {
"message": "Pin this page's IPFS resources to your node to have a local copy that's available offline and never thrown away.",
"description": "A menu item tooltip in Browser Action pop-up (panel_pinCurrentIpfsAddressTooltip)"
"panel_importCurrentIpfsAddressTooltip": {
"message": "Import this tab's IPFS resource to your Files to have a persistent local copy that's available offline and never thrown away.",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jessicaschilling this is the only change in UI, lmk if the label and tooltip explainer could be improved 🙏

import-to-Files-2021-05-07--21-50-40

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lidel Maybe "on My Node" rather than "at"?

@lidel lidel marked this pull request as ready for review May 7, 2021 20:21
Copy link
Contributor

@jessicaschilling jessicaschilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small text suggestions. Thanks!

add-on/_locales/en/messages.json Outdated Show resolved Hide resolved
add-on/_locales/en/messages.json Outdated Show resolved Hide resolved
lidel and others added 2 commits May 7, 2021 22:58
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
@lidel
Copy link
Member Author

lidel commented May 10, 2021

Thanks! Final look:

2021-05-10--13-53-29

This will confuse existing users who are used to seeing low level pin controls there, but the new flow is way more user-friendly and enables users to do remote pinning with UI from webui v2.12: ipfs/ipfs-gui#91

@lidel lidel merged commit 7aba6d9 into main May 10, 2021
@lidel lidel deleted the feat/import-to-mfs branch May 10, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants