Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: URI router preserving the URI path #950

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Conversation

lidel
Copy link
Member

@lidel lidel commented Dec 11, 2020

Some improvements to the intermediate router page we use for URI support:

👉 Open "Test" links in incognito window, it will use public gateway as a fallback and give better feeling of how things behave when network is slow.

- we preserve path, so URIs like below work:
  #ipfs%3A%2F%2FQmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco%2Fwiki%2FDiego_Maradona.html
- hide error UI and display "Processing IPFS request.." while
  redirecting for a nicer UX (no error flash)

TODO: add support for dnslink names in ipns namespace
removes cids library and delegates all the conversion to path-router at
the subdomain gateway. we still check for broken CIDv0 for a nice UX.
this removes the need for bumping library version when new
encoding/codec is added, making this more future proof
@lidel lidel marked this pull request as ready for review January 7, 2021 01:40
@lidel lidel modified the milestones: v2.16, v2.17 Jan 7, 2021
@lidel
Copy link
Member Author

lidel commented Jan 7, 2021

Merging as-is, so we can have more eyes on it in Beta channel.

@fred-wang FYSA we are still waiting for ipfs/kubo#7802 - until that lands there is an improved router at:

https://bafkreiacamq42cltx3ussmxb2ey3mmpisthrs3kelwuxnwt7oofvqsjvgm.ipfs.dweb.link/#%s

Demo: https://bafkreiacamq42cltx3ussmxb2ey3mmpisthrs3kelwuxnwt7oofvqsjvgm.ipfs.dweb.link/#ipfs%3A%2F%2FQmXoypizjW3WknFiJnKLwHCnL72vedxjQkDDP1mXWo6uco%2Fwiki%2FDiego_Maradona.html

@lidel lidel merged commit b768b39 into master Jan 7, 2021
@lidel lidel deleted the fix/uri-router-paths branch January 7, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant