fix: recovery quirks in Firefox and Chromium #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- listen only for webRequest.ResourceType=main_frame - reuse existing tab - deduplicate onErrorOccurred events on Chrome Closes #805
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes small quirks that did not break recovery, but made it bit confusing or inefficient.
fix: duplicated recovery tabs in Chromium
Deduplicate
onErrorOccurredevents: sometimes Chrome produces two, possibly due to lack of async functions in webRequest APIsCloses #805
fix: skip requests from DNS fixup logic in Firefox
Firefox automatically adds 'www.' to TLD+1 names if initial DNS lookup failed.
This produced bogus request+error which recovery logic is now aware of and ignores.
Closes #804
Other
onErrorOccurrednon-async (only Firefox supports those)webRequest.ResourceType=main_frame