Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox DNS recovery clashes with IPFS recovery #804

Closed
lidel opened this issue Oct 28, 2019 · 0 comments · Fixed by #807
Closed

Firefox DNS recovery clashes with IPFS recovery #804

lidel opened this issue Oct 28, 2019 · 0 comments · Fixed by #807
Assignees
@lidel
Labels
area/firefox Issues related to Mozilla Firefox kind/bug A bug in existing code (including security flaws)

Comments

@lidel
Copy link
Member

lidel commented Oct 28, 2019 •
edited
Loading

DNS recovery was added in #797

Problem

Entering http://almonit.eth in Firefox:

2019-10-28--14-37-52

fails, and triggers internal fallback to retry with www. suffix.

This causes two DNS failures and recovery of www. version is opened on top of original one:

2019-10-28--14-37-31

Solutions

  • dedupe subsequent recovery calls?
    • eg. check if non-www. was recovered in the past 30 seconds, do nothing if true
@lidel lidel added kind/bug A bug in existing code (including security flaws) area/firefox Issues related to Mozilla Firefox labels Oct 28, 2019
@lidel lidel mentioned this issue Oct 28, 2019
Closed
@lidel lidel self-assigned this Oct 30, 2019
lidel added a commit that referenced this issue Oct 30, 2019
@lidel
fix: skip requests from DNS fixup logic in Firefox
6c162fe 
Firefox automatically adds 'www.' to TLD+1 names if initial DNS lookup failed.
This produced bogus request+error which recovery  logic should ignore.

Closes #804
@lidel lidel mentioned this issue Oct 30, 2019
Merged
lidel added a commit that referenced this issue Oct 30, 2019
@lidel
fix: recovery quirks in Firefox and Chromium (#807)
04a8ca2 
This fixes small quirks that did not break recovery,
but made it bit confusing or inefficient. 

* fix: duplicated recovery tabs in Chromium

Deduplicate `onErrorOccurred` events: sometimes Chrome produces two, possibly due to lack of async functions in webRequest APIs

Closes #805

* fix: skip requests from DNS fixup logic in Firefox

Firefox automatically adds 'www.' to TLD+1 names if initial DNS lookup failed.
This produced bogus request+error which recovery logic is now aware of and ignores.

Closes #804

* Other

- make `onErrorOccurred` non-async (only Firefox supports those)
- listen only for errors when `webRequest.ResourceType`=`main_frame`
- reuse existing tab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
area/firefox Issues related to Mozilla Firefox kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: recovery quirks in Firefox and Chromium ipfs/ipfs-companion
1 participant
@lidel