Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request unlimited storage for embedded js-ipfs #703

Closed
lidel opened this issue Mar 28, 2019 · 0 comments · Fixed by #714
Closed

Request unlimited storage for embedded js-ipfs #703

lidel opened this issue Mar 28, 2019 · 0 comments · Fixed by #714
Assignees
@lidel
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo

Comments

@lidel
Copy link
Member

lidel commented Mar 28, 2019 •
edited
Loading

Seems that Firefox finally added support for unlimited storage.
This is a good news, as it solves the issue of local datastore running out of space when embedded js-ipfs is used and enables us to control storage limit via ipfs config alone.

The unlimitedStorage permission:

  • enables extensions to exceed any quota imposed by the storage.local API
  • in Firefox, enables extensions to create a "persistent" IndexedDB database, without the browser prompting the user for permission at the time the database is created.

Only ask for "unlimitedStorage" permission if you expect your extension's local data storage to exceed 5MB if it's not going to exceed that amount, don't ask for it.
– src

Refs.
@lidel lidel added help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo exp/novice Someone with a little familiarity can pick up labels Mar 28, 2019
lidel added a commit that referenced this issue Apr 16, 2019
@lidel
feat: unlimited storage for embedded js-ipfs
a5784f2 
Firefox added support for unlimited storage, let's request it.

Closes #703
@lidel lidel mentioned this issue Apr 16, 2019
Merged
@ghost ghost assigned lidel Apr 16, 2019
@ghost ghost added the status/in-progress In progress label Apr 16, 2019
@ghost ghost removed the status/in-progress In progress label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/maintenance Work required to avoid breaking changes or harm to project's status quo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: unlimited storage for embedded js-ipfs ipfs/ipfs-companion
1 participant
@lidel