Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect ipfs://example.net to ipns:// #534

Closed
ghost opened this issue Jul 17, 2018 · 1 comment · Fixed by #748
Closed

Redirect ipfs://example.net to ipns:// #534

ghost opened this issue Jul 17, 2018 · 1 comment · Fixed by #748
Assignees
@lidel
Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature
Milestone
2018-Q4

Comments

@ghost
Copy link

ghost commented Jul 17, 2018

It happens to me all the time that I type in ipfs://some.domain instead of ipns://some.domain -- do y'all think it'd make sense to visibly redirect in that case?
@ghost ghost added the kind/enhancement A net-new feature or improvement to an existing feature label Jul 17, 2018
@lidel
Copy link
Member

lidel commented Jul 18, 2018 •
edited
Loading

Yes 👍 👍
I was about to do it as a part of #533, but it makes sense to do it for old-school redirect-based handlers as well.

@lidel lidel added this to the 2018-Q3 milestone Jul 18, 2018
@lidel lidel modified the milestones: 2018-Q3, 2018-Q4 Sep 20, 2018
@lidel lidel added the status/ready Ready to be worked label Sep 22, 2018
@lidel lidel mentioned this issue Aug 3, 2019
Closed
@lidel lidel added exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue UX labels Aug 3, 2019
lidel added a commit that referenced this issue Aug 20, 2019
@lidel
feat: support ipfs://{dnslink}
0e0fd90 
This adds support for resolving DNSLink via ipfs:// protocol handler
For now it is just a redirect to proper /ipns/ path, but should improve
UX in the long run.

Closes #534
@lidel lidel self-assigned this Aug 20, 2019
@lidel lidel removed good first issue Good issue for new contributors help wanted Seeking public contribution on this issue status/ready Ready to be worked labels Aug 20, 2019
@lidel lidel mentioned this issue Aug 20, 2019
Merged
lidel added a commit that referenced this issue Sep 11, 2019
@lidel
feat: support ipfs://{dnslink} (#748)
7ba096d 
* fix: redirect-based handler vs no redirect on ipfs.io

Disabling redirect does it for all subdomains.
We use gateway.ipfs.io as intermediate step when handling
`ipfs://` in firefox, which resulted in a bizzarre edge case.

This change restores `ipfs://` handler when redirect on ipfs.io is
disabled.

* feat: support ipfs://{dnslink}

This adds support for resolving DNSLink via ipfs:// protocol handler
For now it is just a redirect to proper /ipns/ path, but should improve
UX in the long run.

Closes #534
@github-actions github-actions bot mentioned this issue Feb 16, 2023
Closed
@github-actions github-actions bot mentioned this issue Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
exp/novice Someone with a little familiarity can pick up kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
2018-Q4
1 participant
@lidel