Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MV3] Toggling redirect per website does not work #1243

Closed
Tracked by #1152
lidel opened this issue Jul 21, 2023 · 2 comments
Closed
Tracked by #1152

[MV3] Toggling redirect per website does not work #1243

lidel opened this issue Jul 21, 2023 · 2 comments
Assignees
@whizzzkid
Labels
kind/bug A bug in existing code (including security flaws) mv3-beta-bugs P0 Critical: Tackled by core team ASAP

Comments

@lidel
Copy link
Member

lidel commented Jul 21, 2023 •
edited
Loading

Found while reviewing #1182

Old behavior

Clicking on the toggle does two things

  • adds a redirect exception which disables redirect for the specific Origin
  • reloads the page from original URL

(and toggling it back re-enables redirect for that origin and reloads page so it loads from local gateway again)

2023-07-21_19-32

Bug in MV3

Clicking does nothing – local URL is still in address bar, and opening website again still redirects.

2023-07-21_19-29
@lidel lidel added need/triage Needs initial labeling and prioritization kind/bug A bug in existing code (including security flaws) mv3-beta-bugs labels Jul 21, 2023
@lidel lidel mentioned this issue Jul 21, 2023
Merged
@SgtPooki SgtPooki added P0 Critical: Tackled by core team ASAP and removed need/triage Needs initial labeling and prioritization labels Jul 24, 2023
@SgtPooki
Copy link
Member

assigned to @whizzzkid

@whizzzkid whizzzkid mentioned this issue Aug 2, 2023
Open
@whizzzkid whizzzkid mentioned this issue Sep 5, 2023
Merged
@whizzzkid
Copy link
Contributor

Closed with #1266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whizzzkid whizzzkid

Labels
kind/bug A bug in existing code (including security flaws) mv3-beta-bugs P0 Critical: Tackled by core team ASAP
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lidel @SgtPooki @whizzzkid