Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI windows-tests failing #1071

Closed
SgtPooki opened this issue Mar 25, 2022 · 2 comments
Closed

CI windows-tests failing #1071

SgtPooki opened this issue Mar 25, 2022 · 2 comments
Assignees
@lidel
Labels
kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/test Testing work status/blocked Unable to be worked further until needs are met topic/ci Continuous integration

Comments

@SgtPooki
Copy link
Member

@lidel why did the windows-latest tests fail on the merge of #1064 (comment)? we need to address that.

  1. https://github.com/ipfs/ipfs-companion/runs/5412550268?check_suite_focus=true
  2. https://github.com/ipfs/ipfs-companion/runs/5412542573?check_suite_focus=true
@SgtPooki SgtPooki added the need/triage Needs initial labeling and prioritization label Mar 25, 2022
@SgtPooki SgtPooki added kind/test Testing work topic/ci Continuous integration labels Mar 25, 2022
@lidel lidel added kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo and removed need/triage Needs initial labeling and prioritization labels Mar 25, 2022
@lidel
Copy link
Member

lidel commented Mar 25, 2022 •
edited
Loading

  • ipfs-companion was not updated for a while and Node / NPM ecosystem is very sensitive to entropy

  • We will rewrite companion fanyway due to What to do about Manifest V3 #666 (wip in feat: MV3 boilerplate #1044), but that may not happen until the end of this year (we need to finish MV3 work before 2023, Google started removing MV2 support already).

    • 👉 If we want to fix this before MV3 ships, then we would have to finish refactor: necromancy to restore MV2 build #1054 where I already updated dependencies and webpack build. sadly, got distracted by higher priority work and never finished it. I may get back to it at some point after go-ipfs 0.13 ships and i have more free time.
      • @SgtPooki You probably don't want to look into MV2 – this is a legacy code that will go away by the end of 2022 anyway, so if you want to look into companion, I'd only look into MV3 version.

@lidel lidel added the status/blocked Unable to be worked further until needs are met label Mar 25, 2022
@lidel
Copy link
Member

lidel commented Sep 26, 2022

Resolved by #1094

@lidel lidel closed this as completed Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo kind/test Testing work status/blocked Unable to be worked further until needs are met topic/ci Continuous integration
Projects
No open projects
IPFS-GUI (PL EngRes)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @SgtPooki