feat: save "Path to store imported files" preference from import page #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
approved these changes
Jul 12, 2022
SgtPooki
added
the
status/blocked
lidel
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1028
About
When a user specified a custom path to store imported file while importing with the quick import popup, the path will be saved to preference and will be automatically applied next time.
Remarks
The issue opener suggests to save path to preference as long as the textbox lost focus.
I have concern that, sometimes the path might be incomplete / not valid when user lost focus of the textbox.
So for the code I commit, I save the path to preference after a successful import to make sure the path is completed already and is valid
Please let me know if you would like me to do any other approaches.