Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use StringFlag instead of StringSliceFlag #841

Closed
kishansagathiya opened this issue Jul 18, 2019 · 0 comments · Fixed by #876
Closed

Use StringFlag instead of StringSliceFlag #841

kishansagathiya opened this issue Jul 18, 2019 · 0 comments · Fixed by #876
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@kishansagathiya
Copy link
Contributor

StringSliceFlag is not an user friendly option.

You have to use it like ipfs-cluster init --peers <multiaddress1> --peers <multiaddress2>
If you try ipfs-cluster init --peers <multiaddress1>,<multiaddress2>, it would assume <multiaddress1>,<multiaddress2> to be the first entry in the string slice

Use StringFlag instead and split string with ,

There are two occurrences of this flag https://github.com/ipfs/ipfs-cluster/search?q=StringSliceFlag&unscoped_q=StringSliceFlag
@kishansagathiya kishansagathiya added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up labels Jul 18, 2019
@hsanjuan hsanjuan added P1 High: Likely tackled by core team if no one steps up and removed P2 Medium: Good to have, but can wait until someone steps up labels Jul 23, 2019
@kishansagathiya kishansagathiya mentioned this issue Aug 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use string flag instead of string slice ipfs-cluster/ipfs-cluster
2 participants
@hsanjuan @kishansagathiya