Feat/rest/client: auto-handling of libp2p endpoints #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
hsanjuan
force-pushed
the
fix/client-resolve-panic
branch
from
2aef08a to
36b8990
Compare
This removes PeerAddr and uses APIAddr directly, figuring out if it is a Peer multiaddress or not. PeerAddr is actually kept for compatiblity. It also fixes a bad panic when resolving returned 0 results License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
hsanjuan
force-pushed
the
fix/client-resolve-panic
branch
from
36b8990 to
522791d
Compare
hsanjuan
added
need/review
lanzafame
reviewed
Aug 13, 2018
api/rest/client/client.go
Outdated
| // (takes precedence over host:port). It this address contains | ||
| // an /ipfs/, /p2p/ or /dnsaddr, the API will be contacted | ||
| // through a libp2p tunnel, thus getting encryption for | ||
| // free. The latter overrides any SSL configurations. |
There was a problem hiding this comment.
The latter overrides any SSL configurations.
I am not sure what is going to override any SSL configurations? On first read, I thought latter was referring to /dnsaddr but that doesn't make much sense.
License: MIT Signed-off-by: Hector Sanjuan <code@hector.link>
|
@lanzafame should be good now |
lanzafame
approved these changes
Aug 14, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes PeerAddr and uses APIAddr directly, figuring out if it is
a Peer multiaddress or not.
PeerAddr is actually kept for compatiblity.
It also fixes a bad panic when resolving returned 0 results
License: MIT
Signed-off-by: Hector Sanjuan code@hector.link