-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API endpoint for Peer Monitor metrics #449
Labels
exp/novice
Someone with a little familiarity can pick up
help wanted
Seeking public contribution on this issue
kind/enhancement
A net-new feature or improvement to an existing feature
P2
Medium: Good to have, but can wait until someone steps up
Comments
kishansagathiya
added a commit
to kishansagathiya/ipfs-cluster
that referenced
this issue
Oct 7, 2018
Opened new endpoint `GET /health/metrics/<name>` which would respond with metrics of type <name> License: MIT Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
4 tasks
kishansagathiya
added a commit
to kishansagathiya/ipfs-cluster
that referenced
this issue
Oct 7, 2018
Support the new endpoint for later metrics in `rest/api/client` Support the new method created in `rest/api/client` in ipfs-cluster-ctl. i.e. `ipfs-cluster-ctl health metrics <name>` would show the peers and the last list of metrics logged for each as returned by the Peer Monitor, in a friendly way. License: MIT Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya
added a commit
to kishansagathiya/ipfs-cluster
that referenced
this issue
Oct 21, 2018
Rename method PeerMonitorLatestMetrics to Metrics Addressing first round of comment as in ipfs-cluster#572 (review) License: MIT Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya
added a commit
to kishansagathiya/ipfs-cluster
that referenced
this issue
Oct 21, 2018
Opened new endpoint `GET /health/metrics/<name>` which would respond with metrics of type <name> License: MIT Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya
added a commit
to kishansagathiya/ipfs-cluster
that referenced
this issue
Oct 21, 2018
Support the new endpoint for later metrics in `rest/api/client` Support the new method created in `rest/api/client` in ipfs-cluster-ctl. i.e. `ipfs-cluster-ctl health metrics <name>` would show the peers and the last list of metrics logged for each as returned by the Peer Monitor, in a friendly way. License: MIT Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
kishansagathiya
added a commit
to kishansagathiya/ipfs-cluster
that referenced
this issue
Oct 21, 2018
Rename method PeerMonitorLatestMetrics to Metrics Addressing first round of comment as in ipfs-cluster#572 (review) License: MIT Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
Closed
hsanjuan
added a commit
that referenced
this issue
Oct 22, 2018
Issue #449 API endpoint for Peer Monitor metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exp/novice
Someone with a little familiarity can pick up
help wanted
Seeking public contribution on this issue
kind/enhancement
A net-new feature or improvement to an existing feature
P2
Medium: Good to have, but can wait until someone steps up
Basic information
Description
The Peer Monitor collects metrics and stores them by type and by peer.
The information from LatestMetrics() should be inspectable by the user through the rest api.
This implies:
GET /health/metrics/<name>
)api/rest
component (the metrics can be requested via RPC request toPeerMonitorLatestMetrics
)rest/api/client
ipfs-cluster-ctl
. i.e.ipfs-cluster-ctl health metrics <name>
would show the peers and the last list of metrics logged for each as returned by the Peer Monitor, in a friendly way.The text was updated successfully, but these errors were encountered: