Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition /ipfs multiaddr handling to /p2p #431

Closed
lanzafame opened this issue May 25, 2018 · 2 comments · Fixed by #877
Closed

Transition /ipfs multiaddr handling to /p2p #431

lanzafame opened this issue May 25, 2018 · 2 comments · Fixed by #877
Assignees
@kishansagathiya
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked

Comments

@lanzafame
Copy link
Contributor

See multiformats/multiaddr#64 and multiformats/go-multiaddr#66.

Places where we manually add /ipfs/:
api/util.go:45
api/util.go:61
pstoremgr/pstoremgr.go:106
api/rest/client/client_test.go:63
peer_manager_test.go:36
consensus/raft/consensus_test.go:31
ipfscluster_test.go:238
@lanzafame lanzafame added kind/enhancement A net-new feature or improvement to an existing feature exp/novice Someone with a little familiarity can pick up P3 Low: Not priority right now labels May 25, 2018
@hsanjuan
Copy link
Collaborator

ah, finally. We need to wait until this is bubbled in libp2p.

@hsanjuan hsanjuan added the status/blocked Unable to be worked further until needs are met label May 25, 2018
@hsanjuan hsanjuan added help wanted Seeking public contribution on this issue status/ready Ready to be worked and removed status/blocked Unable to be worked further until needs are met labels Apr 25, 2019
@hsanjuan
Copy link
Collaborator

This can be done now

@hsanjuan hsanjuan added P1 High: Likely tackled by core team if no one steps up and removed P3 Low: Not priority right now labels Jul 23, 2019
@kishansagathiya kishansagathiya mentioned this issue Aug 11, 2019
Merged
@kishansagathiya kishansagathiya self-assigned this Aug 28, 2019
@hsanjuan hsanjuan mentioned this issue Sep 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kishansagathiya kishansagathiya

Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use p2p protocol name over ipfs for multiaddr ipfs-cluster/ipfs-cluster
3 participants
@hsanjuan @lanzafame @kishansagathiya