Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #203: Assign peers and bootstrap when parsing the configuration #204

Merged
merged 2 commits into from
Oct 26, 2017
Merged

Fix #203: Assign peers and bootstrap when parsing the configuration #204

merged 2 commits into from
Oct 26, 2017

Conversation

hsanjuan
Copy link
Collaborator

License: MIT
Signed-off-by: Hector Sanjuan hector@protocol.ai

@hsanjuan
Fix #203: Assign peers and bootstrap when parsing the configuration
af091cc 
License: MIT
Signed-off-by: Hector Sanjuan <hector@protocol.ai>
@hsanjuan hsanjuan self-assigned this Oct 26, 2017
@hsanjuan hsanjuan requested a review from ZenGround0 October 26, 2017 11:43
@ghost ghost added the status/in-progress In progress label Oct 26, 2017
@hsanjuan
Copy link
Collaborator Author

good screw up of mine here...

@hsanjuan
Issue #203: Add test for the issue
289ac77 
License: MIT
Signed-off-by: Hector Sanjuan <hector@protocol.ai>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 74.745% when pulling 289ac77 on fix/203-peers-ignored into f002dd1 on master.

ZenGround0
ZenGround0 approved these changes Oct 26, 2017
View reviewed changes
Copy link
Collaborator

@ZenGround0 ZenGround0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 74.81% when pulling 289ac77 on fix/203-peers-ignored into f002dd1 on master.

@hsanjuan hsanjuan merged commit 3c48c35 into master Oct 26, 2017
@ghost ghost removed the status/in-progress In progress label Oct 26, 2017
@hsanjuan hsanjuan deleted the fix/203-peers-ignored branch October 26, 2017 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZenGround0 ZenGround0 ZenGround0 approved these changes

Assignees

@hsanjuan hsanjuan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsanjuan @coveralls @ZenGround0