Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemd notify support #1144

Closed
RubenKelevra opened this issue May 30, 2020 · 4 comments
Closed

systemd notify support #1144

RubenKelevra opened this issue May 30, 2020 · 4 comments
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@RubenKelevra
Copy link
Collaborator

It would be nice to have systemd-notify support, to start applications using ipfs-cluster-service after the service has been successfully started.

IPFS has already support for this service type:

ipfs/kubo@87f2e38

@RubenKelevra RubenKelevra added the need/triage Needs initial labeling and prioritization label May 30, 2020
@hsanjuan hsanjuan added exp/novice Someone with a little familiarity can pick up effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels May 30, 2020
@hsanjuan
Copy link
Collaborator

And the default service file should require ipfs to start before cluster itself.

@RubenKelevra
Copy link
Collaborator Author

RubenKelevra commented May 31, 2020

Yes.

I already have a service file created for my server, going to create a PR for it as soon as I have some time to look at the hardening options.

@Luflosi
Copy link

Luflosi commented Mar 8, 2021

Have you had some time to look at the hardening options yet?

@hsanjuan hsanjuan added this to the Release v1.0.7 milestone Apr 14, 2023
@hsanjuan
Copy link
Collaborator

Fixed by #1898 I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

3 participants