fix: support https?://<dnsLink>.ipns.<gateway> urls #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
commented
Mar 11, 2024
Comment on lines
+50
to
+76
| /** | ||
| * For dnslinks see https://specs.ipfs.tech/http-gateways/subdomain-gateway/#host-request-header | ||
| * DNSLink names include . which means they must be inlined into a single DNS label to provide unique origin and work with wildcard TLS certificates. | ||
| */ | ||
|
|
||
| // DNS label can have up to 63 characters, consisting of alphanumeric | ||
| // characters or hyphens -, but it must not start or end with a hyphen. | ||
| const dnsLabelRegex = /^[a-zA-Z0-9]([a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?$/ | ||
|
|
||
| /** | ||
| * Checks if label looks like inlined DNSLink. | ||
| * (https://specs.ipfs.tech/http-gateways/subdomain-gateway/#host-request-header) | ||
| */ | ||
| function isInlinedDnsLink (label: string): boolean { | ||
| return dnsLabelRegex.test(label) && label.includes('-') && !label.includes('.') | ||
| } | ||
|
|
||
| /** | ||
| * DNSLink label decoding | ||
| * * Every standalone - is replaced with . | ||
| * * Every remaining -- is replaced with - | ||
| * | ||
| * @example en-wikipedia--on--ipfs-org.ipns.example.net -> example.net/ipns/en.wikipedia-on-ipfs.org | ||
| */ | ||
| function dnsLinkLabelDecoder (linkLabel: string): string { | ||
| return linkLabel.replace(/--/g, '%').replace(/-/g, '.').replace(/%/g, '-') | ||
| } |
There was a problem hiding this comment.
| cid = resolveResult?.cid | ||
| resolvedPath = resolveResult?.path | ||
| log.trace('resolved %s to %c', cidOrPeerIdOrDnsLink, cid) | ||
| log.trace('resolved %s to %c', decodedDnsLinkLabel, cid) | ||
| ipnsCache.set(cidOrPeerIdOrDnsLink, resolveResult, 60 * 1000 * 2) |
There was a problem hiding this comment.
caching the originally given dnsLink
github-actions bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
## @helia/verified-fetch [1.1.2](https://github.com/ipfs/helia-verified-fetch/compare/@helia/verified-fetch-1.1.1...@helia/verified-fetch-1.1.2) (2024-03-11) ### Bug Fixes * support https?://<dnsLink>.ipns.<gateway> urls ([#16](#16)) ([0ece19a](0ece19a))
|
🎉 This PR is included in version 1.1.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Feat: Support
https?://<dnsLink>.ipns.<domain>URLsDescription
helia-http-gateway and helia-service-worker-gateway can now pass any urls they receive directly to @helia/verfied-fetch without having to do any URL parsing.
Notes & open questions
Change checklist