Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

delete expandSparse func in writeAt #46

Closed
wants to merge 1 commit into from
Closed

delete expandSparse func in writeAt #46

wants to merge 1 commit into from

Conversation

kjzz
Copy link
Contributor

@kjzz kjzz commented Oct 30, 2018

issue #43

@kjzz kjzz requested a review from schomatis as a code owner October 30, 2018 02:44
@schomatis
Copy link
Contributor

Thanks for the PR @kjzz but at the moment there's no rush to delete this code, this should be part of a bigger refactoring of the DagModifier.

@schomatis schomatis closed this Oct 30, 2018
@kjzz
Copy link
Contributor Author

kjzz commented Oct 30, 2018

So @schomatis if you have any refactoring plan , please ping me. I am wiling to do for this,Thx a lot

@schomatis
Copy link
Contributor

Great, once the DAG reader is refactored (after ipfs/go-ipld-format#39 gets merged) I'll open another issue about reviewing the DAG modifier.

@kjzz kjzz deleted the fix/writeAt branch October 30, 2018 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schomatis schomatis Awaiting requested review from schomatis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kjzz @schomatis