chore: dont docker tag rc as latest #8055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add guard for rc releases; publish them to docker hub with the matching git tag - make the semver regex stricter and only publish as latest when a full semver tag with no pre-release suffix is the name of the git tag. - add `release` tag as an alias of `latest` as per #3999 (comment) Tested manually as the push-docker-tag.sh script is set up for it: ```shell ./push-docker-tags.sh $(date -u +%F) testingsha release v0.9.0-test dry Nothing to do. No docker tag defined for branch: release, tag: v0.9.0-test ./push-docker-tags.sh $(date -u +%F) testingsha release v0.9.0-rc1 dry DRY RUN! I would have tagged and pushed the following... docker tag ipfs/go-ipfs:wip ipfs/go-ipfs:v0.9.0-rc1 docker push ipfs/go-ipfs:v0.9.0-rc1 ./push-docker-tags.sh $(date -u +%F) testingsha release v0.9.0 dry DRY RUN! I would have tagged and pushed the following... docker tag ipfs/go-ipfs:wip ipfs/go-ipfs:v0.9.0 docker push ipfs/go-ipfs:v0.9.0 DRY RUN! I would have tagged and pushed the following... docker tag ipfs/go-ipfs:wip ipfs/go-ipfs:latest docker push ipfs/go-ipfs:latest DRY RUN! I would have tagged and pushed the following... docker tag ipfs/go-ipfs:wip ipfs/go-ipfs:release docker push ipfs/go-ipfs:release ``` fixes #3999 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
gammazero
reviewed
Apr 6, 2021
gammazero
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
releasetag as an alias oflatestas per Publishing of docker images #3999 (comment)Tested manually as the push-docker-tag.sh script is set up for it:
fixes #3999
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io