Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: bump minimal dependency to 1.14.4 #7419

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

RubenKelevra
Copy link
Contributor

due to major bugfixes in the .4 release

@ribasushi
Copy link
Contributor

major bugfixes in the .4 release

@RubenKelevra out of curiosity: which bugfix are you referring to?

@Stebalien Stebalien merged commit 11be1c5 into ipfs:master Jun 5, 2020
@Stebalien
Copy link
Member

golang/go#38933? Probably not critical, but anyone on 1.14.2 can upgrade to 1.14.4.

@RubenKelevra
Copy link
Contributor Author

Yes, had some hangs on startup lately. Thought it was a different fix (but mixed up the ticket numbers).

I was about to create a ticket with some stack traces... but it's gone since the go update.

I just wanted to make sure people build IPFS with the latest bugfixes, to avoid trying to track issues already fixed in Go down.

@Stebalien
Copy link
Member

Fair enough.

I just wanted to make sure people build IPFS with the latest bugfixes, to avoid trying to track issues already fixed in Go down.

In general, we try to stick to the lowest supported release unless there's a know nissue as most distros don't update immediately.

@RubenKelevra
Copy link
Contributor Author

I just wanted to make sure people build IPFS with the latest bugfixes, to avoid trying to track issues already fixed in Go down.

In general, we try to stick to the lowest supported release unless there's a know nissue as most distros don't update immediately.

Understandably, but I don't get why repos are lagging behind with important patches.

@RubenKelevra RubenKelevra deleted the feat/require_go_1.14.4 branch June 10, 2020 21:38
@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants