ipfs namespace is now being provided to prometheus #6643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Sep 16, 2019
core/corehttp/metrics.go
Outdated
| Subsystem: "http", | ||
| ConstLabels: prometheus.Labels{"handler": handlerName}, | ||
| Objectives: map[float64]float64{0.5: 0.05, 0.9: 0.01, 0.99: 0.001}, | ||
| } | ||
|
|
||
| reqCnt := prometheus.NewCounterVec( | ||
| prometheus.CounterOpts{ | ||
| Namespace: opts.Namespace, |
There was a problem hiding this comment.
Ahh yes we should.
|
@olizilla @Stebalien fixed. thanks for the nudge |
Stebalien
approved these changes
Oct 23, 2019
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
…mespace ipfs namespace is now being provided to prometheus This commit was moved from ipfs/kubo@4a10220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes what was a rather confusing issue in prometheus where the
http_response_size_bytesmetrics was confused to be coming from nginx but was actually from ipfs.