Document the AddrFilters option #6459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsanjuan
force-pushed
the
doc/addrFilters
branch
from
f5e4603
to
cf19522
Compare
Stebalien
requested changes
Jun 27, 2019
docs/config.md
Outdated
| the default listen port on every IP of the the local network IP range. This | ||
| improves autodiscovery of other daemons in the same network, but may also | ||
| trigger netscan alerts on some hosting providers or cause strain in some | ||
| setups. |
There was a problem hiding this comment.
This should explain why we do that and how. That is, we're not intentionally dialing every address one-by-one.
(Otherwise, we'll get even more questions)
There was a problem hiding this comment.
Isn't the why to improve autodiscovery? I don't have much idea about the how.. is it random?
There was a problem hiding this comment.
No. We end up dialing local addresses because peers publish these addresses in the DHT. We aren't intentionally scanning the local network.
There was a problem hiding this comment.
Ah, will update accordingly. Thanks!
docs/config.md
Outdated
| The `server` configuration profile fills up this list with sensible defaults, | ||
| preventing scans to most common local network (`10.0.0.0/8` or | ||
| `192.168.0.0/16`), but you should always check settings against your own | ||
| network and/or hosting provider. |
There was a problem hiding this comment.
It filters all non-routable addresses per the IANA special registry.
Shouldn't have to scan through an old issue to figure out what is happening and why this is super important.
Stebalien
force-pushed
the
doc/addrFilters
branch
from
cf19522
to
530c94e
Compare
Stebalien
force-pushed
the
doc/addrFilters
branch
from
530c94e
to
72122a5
Compare
Stebalien
approved these changes
Jul 12, 2019
|
hey, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shouldn't have to scan through an old issue to figure out what is happening
and why this is super important.