Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin: fix concurrent map access race #6419

Merged
merged 1 commit into from
Jun 6, 2019
Merged

pin: fix concurrent map access race #6419

merged 1 commit into from
Jun 6, 2019

Conversation

Stebalien
Copy link
Member

Not sure why this didn't show up sooner.

fixes #6418

Not sure why this didn't show up sooner.

fixes #6418
@Stebalien
Copy link
Member Author

cc @postables for review.

Copy link
Contributor

@bonedaddy bonedaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Stebalien Stebalien merged commit c7dc3c3 into master Jun 6, 2019
@Stebalien Stebalien deleted the fix/6418 branch June 6, 2019 22:50
@zhjgit
Copy link

zhjgit commented Jun 27, 2019

#6418 After which version, please fix the bug. @Stebalien @postables I'm currently using go-ipfs 0.4.18 and this problem has arisen.

@Stebalien
Copy link
Member Author

We need to cut a release for this.

@zhjgit
Copy link

zhjgit commented Jun 27, 2019

@Stebalien When will go-ipfs 0.4.18 be released to fix the bug? I need to use it urgently.

@Stebalien
Copy link
Member Author

Please build the latest master. We're planning on cutting an RC for the next release ASAP (days) but I can't give an exact date.

@zhjgit
Copy link

zhjgit commented Jun 27, 2019

I can't use the latest version. I only need version 0.4.18

@Stebalien
Copy link
Member Author

We will not backport to 0.4.18. What's your issue with the latest version?

@zhjgit
Copy link

zhjgit commented Jun 28, 2019

That's the problem. #6418

Stebalien added a commit that referenced this pull request Jul 4, 2019
pin: fix concurrent map access race
@Stebalien Stebalien mentioned this pull request Jul 12, 2019
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fatal error: concurrent map iteration and map write
3 participants