Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #4558 #5937

Merged
merged 3 commits into from
Jan 23, 2019
Merged

Fixes #4558 #5937

merged 3 commits into from
Jan 23, 2019

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien requested a review from Kubuxu as a code owner January 22, 2019 13:01
@ghost ghost assigned Stebalien Jan 22, 2019
@ghost ghost added the status/in-progress In progress label Jan 22, 2019
@Stebalien Stebalien mentioned this pull request Jan 22, 2019
Closed
@Stebalien Stebalien changed the title Fixes https://github.com/ipfs/go-ipfs/issues/4558 Fixes #4558 Jan 22, 2019
@magik6k @Stebalien
Unixfs.Add nocopy test
19ca1a8 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k @Stebalien
Unixfs: enforce refs on files when using nocopy
b2a5168 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@Stebalien Stebalien force-pushed the fix/nocopy-errors branch 2 times, most recently from 2b442c9 to f4e0065 Compare January 23, 2019 14:07
@Stebalien
Copy link
Member Author

Tried to rebase this but ended up pulling in a bug in go-ipld-git.

@magik6k magik6k self-assigned this Jan 23, 2019
@magik6k magik6k mentioned this pull request Jan 23, 2019
Merged
@magik6k
Copy link
Member

magik6k commented Jan 23, 2019

Pushed a fix - ipfs/go-ipld-git#37

@magik6k magik6k removed their assignment Jan 23, 2019
@magik6k @Stebalien
gx: update go-unixfs to 1.2.14 and go-bitswap to 1.1.21
53e55e3 
(and everything else...)

License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@Stebalien
Copy link
Member Author

Can't approve "my" PR but I didn't write it so... 👍.

@Stebalien Stebalien merged commit 77cd41a into master Jan 23, 2019
@ghost ghost removed the status/in-progress In progress label Jan 23, 2019
@Stebalien Stebalien deleted the fix/nocopy-errors branch January 23, 2019 19:13
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
@Stebalien
Merge pull request ipfs/kubo#5937 from ipfs/fix/nocopy-errors
2503a07 
Fixes #4558

This commit was moved from ipfs/kubo@77cd41a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@Stebalien Stebalien

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stebalien @magik6k