commands: fix a bunch of tiny commands-lib issues #5697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
force-pushed
the
fix/commands-stuff
branch
from
214a715
to
9a52ca1
Compare
* Always check errors returned by emit. Otherwise, we may not notice when the client goes away. * Make sure to use EmitOnce instead of Emit when appropriate. Otherwise, we break javascript. (thanks Magik6k for finding this before we cut the release...) License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
force-pushed
the
fix/commands-stuff
branch
from
9a52ca1
to
e332af8
Compare
magik6k
approved these changes
Oct 30, 2018
|
(there are some fixes in bfffaf0 that are not here) |
|
@magik6k mind making a PR for that pin fix (along with a test). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(thanks Magik6k for finding this before we cut the release...)