Update dist_root #5093
Merged
Update dist_root #5093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
My question is why didnt the jenkins windows builds fail? cc @victorbjelkholm @magik6k |
|
Jenkins manually gets gx/gx-go - https://github.com/ipfs/go-ipfs/blob/7b174188f9ecc8767584c283bdf48017ef9f743c/ci/Jenkinsfile#L109. This is done that way so we can extract logs directly from go tests (could be done as |
|
Also, test result collection for windows is disabled on master now as there is one test failing (results from branch with windows test results enabled: https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fgo-ipfs/detail/misc%2Fci%2Fwin-test-results/3/tests) |
Stebalien
approved these changes
Jun 7, 2018
License: MIT Signed-off-by: Dominic Della Valle <ddvpublic@gmail.com>
|
Signed off the commit to make gitcop happy |
Closed
|
Thanks @djdv, sorry for the delay, my brain confused 'approve' and 'merge' >.> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows
gxbinaries were missing, they've been added but this reference is outdated.Hash taken from
ipfs resolve /ipns/dist.ipfs.ioWithout this, builds are broken on Windows: #5042