Fix key rename command output error

[grokcoder]

fix: Error when renaming keys #4953

License: MIT
Signed-off-by: Xiaoyi Wang wangxiaoyi@hyperchain.cn

[magik6k]

Thanks! Would be great to get a test reproducing this issue before the fix (in test/sharness)

[grokcoder]

@magik6k I don't understand, if I have fixed this issue #4953, how to reproduce it.

test_expect_success "ipfs key rename failed reproduce succeeds" ' ipfs init && ipfs key gen --type=rsa --size=2048 key1 && ipfs key rename key1 key2 2>rename_err && EXPECT="expected a KeyRenameOutput as command result" && grep "$EXPECT" rename_err '
this can reproduce before I fix it, but failed if I fixed it.
So could you please explain it more clearly?

[magik6k]

this can reproduce before I fix it, but failed if I fixed it

That's what I asked for, a test which will fail before the issue was fixed

I looked at the current keystore tests and it looks like there already is a test for rename - https://github.com/ipfs/go-ipfs/blob/master/test/sharness/t0165-keystore.sh#L53, but only in offline mode

Basically, what you want to do is to replace https://github.com/ipfs/go-ipfs/blob/master/test/sharness/t0165-keystore.sh#L72 with something like

test_key_cmd

test_launch_ipfs_daemon

test_expect_success "cleanup" '
  ipfs key rm fooed
'

test_key_cmd

test_kill_ipfs_daemon

[grokcoder]

@magik6k thx for explain, the issue what I fixed is the key rename output msg parse error, not the rename function. The rename function is worked but with error output msg.

[whyrusleeping]

Thanks @grokcoder!