Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix go vet warnings #4859

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Fix go vet warnings #4859

merged 1 commit into from
Mar 23, 2018

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Mar 22, 2018

Before:

$ go vet ./...                
core/builder.go:176: github.com/ipfs/go-ipfs/thirdparty/verifbs.VerifBS composite literal uses unkeyed fields
core/builder.go:205: github.com/ipfs/go-ipfs/thirdparty/verifbs.VerifBSGC composite literal uses unkeyed fields
exit status 1
filestore/fsrefstore.go:80: possible formatting directive in Error call
exit status 1
repo/fsrepo/fsrepo.go:622: self-assignment of value to value
exit status 1
test/dependencies/go-timeout/main.go:24: the cancel function returned by context.WithTimeout should be called, not discarded, to avoid a context leak
exit status 1
thirdparty/notifier/notifier.go:48: return copies lock value: notifier.Notifier contains sync.RWMutex
exit status 1

@magik6k magik6k requested a review from Kubuxu as a code owner March 22, 2018 03:02
@ghost ghost assigned magik6k Mar 22, 2018
@ghost ghost added the status/in-progress In progress label Mar 22, 2018
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@Kubuxu Kubuxu added RFM and removed status/in-progress In progress labels Mar 23, 2018
@whyrusleeping whyrusleeping merged commit 4f601a0 into master Mar 23, 2018
@whyrusleeping whyrusleeping deleted the fix/govet branch March 23, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants