fix: use EmitOnce where only single response is to be sent #4822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #4818 License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
ghost
assigned License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Stebalien
approved these changes
Mar 16, 2018
magik6k
approved these changes
Mar 16, 2018
|
@Kubuxu @victorbjelkholm do we have js-ipfs-api tests running in CI yet? |
|
In any case I think this is ready to go. We'll have to ship another rc, but before we do that, can we make sure theres nothing else weird thats gonna come up? |
|
@whyrusleeping no we don't but go-ipfs artefacts are exported so it should be quite easy to add from js-ipfs-api side. |
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4818
Also fixes pubsub ls breakage.
License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch