Feat/log/uuid #4392
Feat/log/uuid #4392
Conversation
ghost
assigned 
Every log event resulting from a command will have a uuid associated with it License: MIT Signed-off-by: Forrest Weston <forrest@protocol.ai>
License: MIT Signed-off-by: Forrest Weston <forrest@protocol.ai>
frrist
force-pushed
the
feat/log/uuid
branch
from
5c8e135
to
1c3e590
Compare
path/resolver.go
Outdated
| @@ -135,6 +135,7 @@ func (s *Resolver) ResolvePathComponents(ctx context.Context, fpath Path) ([]nod | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| defer log.EventBegin(ctx, "resolvePathComponents", logging.LoggableMap{"parts": parts, "cid": h}).Done() | |||
There was a problem hiding this comment.
In the case that there is an error in the execution of this method, do we want to add a loggable error to the event log (see L143)?
There was a problem hiding this comment.
IMO, yes. We'd probably also want to log the error from L146 as well. Also, this event should probably go at the top and include any errors from SplitAbsPath.
There was a problem hiding this comment.
You can save the result value of EventBegin and add additional data to it.
path/resolver.go
Outdated
| @@ -135,6 +135,7 @@ func (s *Resolver) ResolvePathComponents(ctx context.Context, fpath Path) ([]nod | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| defer log.EventBegin(ctx, "resolvePathComponents", logging.LoggableMap{"parts": parts, "cid": h}).Done() | |||
There was a problem hiding this comment.
IMO, yes. We'd probably also want to log the error from L146 as well. Also, this event should probably go at the top and include any errors from SplitAbsPath.
commands/http/handler.go
Outdated
| @@ -137,6 +138,7 @@ func (i internalHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { | |||
| } | |||
|
|
|||
| ctx, cancel := context.WithCancel(node.Context()) | |||
| ctx = logging.ContextWithLoggable(ctx, loggables.Uuid("requestId")) | |||
There was a problem hiding this comment.
I would move this down below the defer cancel.
If an error occurs during an event add it to the events metadata License: MIT Signed-off-by: Forrest Weston <forrest@protocol.ai>
|
@victorbjelkholm whatsup with jenkins? |
Add an uuid/requestId to root context - this will add a requestId to event logs resulting from a command
Add event logs around path resolution - said logs make use of requestId