Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 80 columns mans tests #3774

Merged
merged 2 commits into from
Mar 10, 2017
Merged

Add 80 columns mans tests #3774

merged 2 commits into from
Mar 10, 2017

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Mar 10, 2017 •
edited
Loading

It is marked as failed right now, as it fails

Part of #2783

@Kubuxu Kubuxu added the status/in-progress In progress label Mar 10, 2017
@Kubuxu Kubuxu added this to the Ipfs 0.4.7 milestone Mar 10, 2017
@Kubuxu
test: fix commands tests
2317ced 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu
test: add test for checking if commands mans lengths are shorter than 80
5489025 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
whyrusleeping
whyrusleeping approved these changes Mar 10, 2017
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@whyrusleeping whyrusleeping merged commit 56bbcc9 into master Mar 10, 2017
@whyrusleeping whyrusleeping deleted the feat/docs/80-chars branch March 10, 2017 22:42
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Ipfs 0.4.7
Development

Successfully merging this pull request may close these issues.
2 participants
@Kubuxu @whyrusleeping