Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block rm: use Marshalers instead of PostRun to process output #3708

Merged
merged 1 commit into from
Feb 20, 2017

Conversation

kevina
Copy link
Contributor

@kevina kevina commented Feb 20, 2017

License: MIT
Signed-off-by: Kevin Atkinson k@kevina.org

License: MIT
Signed-off-by: Kevin Atkinson <k@kevina.org>
@kevina kevina added the status/in-progress In progress label Feb 20, 2017
@kevina
Copy link
Contributor Author

kevina commented Feb 20, 2017

@whyrusleeping When I did a similar think with the filestore utils you thought it would be better to use a Marshalers: #3653 (comment).

@kevina kevina added need/review Needs a review and removed status/in-progress In progress labels Feb 20, 2017
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@whyrusleeping whyrusleeping merged commit 9ff46fb into master Feb 20, 2017
@whyrusleeping whyrusleeping deleted the kevina/block-rm-marshalers branch February 20, 2017 19:42
@Kubuxu Kubuxu added this to the ipfs 0.4.6 milestone Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/review Needs a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants