coreunix: fix Add() docs regarding pinning #3513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
topic/commands:add
hsanjuan
reviewed
Dec 16, 2016
| @@ -251,12 +253,14 @@ func (adder *Adder) outputDirs(path string, fsn mfs.FSNode) error { | |||
| } | |||
| } | |||
|
|
|||
| // Add builds a merkledag from the a reader, pinning all objects to the local | |||
| // datastore. Returns a key representing the root node. | |||
| // Builds a merkledag node from a reader, adds it to the blockstore, | |||
There was a problem hiding this comment.
This is not golint compliant
There was a problem hiding this comment.
Fixed this and the other, and I now have golint installed which looks useful 👍
| func Add(n *core.IpfsNode, r io.Reader) (string, error) { | ||
| return AddWithContext(n.Context(), n, r) | ||
| } | ||
|
|
||
| // Same as Add(), but with a custom context. |
There was a problem hiding this comment.
Also not golint compliant
ghost
force-pushed
the
fix/coreunix-add-docs
branch
from
3b10b44 to
03ad180
Compare
License: MIT Signed-off-by: Lars Gierth <larsg@systemli.org>
ghost
force-pushed
the
fix/coreunix-add-docs
branch
from
03ad180 to
71a03fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3470