Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check if go code is formatted #3421

Merged
merged 2 commits into from
Nov 25, 2016
Merged

Add check if go code is formatted #3421

merged 2 commits into from
Nov 25, 2016

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Nov 24, 2016

No description provided.

@Kubuxu
Remove trailing new-line from pbdagreader.go
1d67c93 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu Kubuxu added the status/in-progress In progress label Nov 24, 2016
ghost
ghost reviewed Nov 24, 2016
View reviewed changes
bin/test-go-fmt
echo "-----------------------------------"
echo "Run 'go fmt ./...' in your source directory"
fi
rm -f "$T"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to exit 1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does.

@Kubuxu
Add test_go_fmt to makefile
21c7ec8 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@whyrusleeping
Copy link
Member

LGTM, been wanting this for a while

@whyrusleeping whyrusleeping merged commit 4511a4a into master Nov 25, 2016
@whyrusleeping whyrusleeping deleted the feat/test/go-fmt branch November 25, 2016 18:51
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Nov 25, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kubuxu @whyrusleeping