cleanup bitswap and handle message send failure slightly better #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
feat/bitswap-cleanup
branch
from
2efe425
to
42e6e54
Compare
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
Kubuxu
reviewed
Nov 27, 2016
| @@ -112,34 +111,36 @@ func New(parent context.Context, p peer.ID, network bsnet.BitSwapNetwork, | |||
|
|
|||
| // Bitswap instances implement the bitswap protocol. | |||
| type Bitswap struct { | |||
| // the peermanager manages sending messages to peers in a way that | |||
| // wont block bitswap operation | |||
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is prep work for the bitswap fixes being discussed in #3398
License: MIT
Signed-off-by: Jeromy why@ipfs.io