bitswap: Don't clear 'active' until Connect calls are finished #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
added
status/in-progress
whyrusleeping
force-pushed
the
fix/bitswap-goro-leak
branch
from
f640a44
to
c779eb5
Compare
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
whyrusleeping
force-pushed
the
fix/bitswap-goro-leak
branch
from
c779eb5
to
b913010
Compare
|
LGTM. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been an issue for a long time, but for some reason the changes to making providers more efficient has made this a much larger problem.
I'm not 100% sure this will solve the excess cpu usage problem we're seeing on the gateways, but its definitely fixing a bug.
License: MIT
Signed-off-by: Jeromy why@ipfs.io