mfs: fix copying into directory with no given filename #2977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
|
LGTM. |
|
cc @Kubuxu for another review |
|
@whyrusleeping I reviewed it technically, not just for my normal review. The Gocode looks solid. Still, double might be good? |
|
👍 Thanks richard! |
|
I was reviewing that ... |
|
|
||
| test_expect_success "copy a file into a directory" ' | ||
| ipfs files cp /foobar /adir/ | ||
| ' |
There was a problem hiding this comment.
This test case could've been created from the get go. Let's test more thoroughly from the beginning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where running
ipfs files cp /something /adirectory/would make a file with a zero length name inside/adirectoryLicense: MIT
Signed-off-by: Jeromy why@ipfs.io