Decapitalized log.Debug messages #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know golang standards that well, but SGTM. |
|
@Kubuxu Me neither. But @whyrusleeping consistently stated that errors should be lowercase - I figure this should be similar. |
| @@ -55,7 +55,7 @@ func NewFileSystem(ipfs *core.IpfsNode, sk ci.PrivKey, ipfspath, ipnspath string | |||
|
|
|||
| // Root constructs the Root of the filesystem, a Root object. | |||
| func (f *FileSystem) Root() (fs.Node, error) { | |||
| log.Debug("Filesystem, get root") | |||
| log.Debug("gilesystem, get root") | |||
There was a problem hiding this comment.
Typo – should be filesystem.
(Your editor may have a 'convert to lowercase' command that avoids this.)
There was a problem hiding this comment.
Good catch, and good call. Thanks.
According to golang standards, these should not be capitalized nor having a trailing period, AFAIK. License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
force-pushed
the
feature/decapitalize-Debug
branch
from
35fba28
to
b6a3435
Compare
|
this LGTM |
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
Decapitalized log.Debug messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to golang standards, these should not be capitalized nor having a trailing period, AFAIK.
License: MIT
Signed-off-by: Richard Littauer richard.littauer@gmail.com