Add test for directly adding hidden file #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ipfs add mountdir/.hello.txt >actual | ||
| ' | ||
|
|
||
| test_expect_success "ipfs add on hiddne file output looks good" ' |
Kubuxu
force-pushed
the
feature/HiddenFilesTests
branch
2 times, most recently
from
2793ae4
to
0aa6f98
Compare
|
It was recently (about last 70 commits) broken and fixed. |
| @@ -30,7 +30,6 @@ test_add_cat_file() { | |||
| echo "added $HASH hello.txt" >expected && | |||
| test_cmp expected actual | |||
| ' | |||
|
|
|||
There was a problem hiding this comment.
lets go ahead and leave this newline here, lol
whyrusleeping
added
status/in-progress
Kubuxu
force-pushed
the
feature/HiddenFilesTests
branch
from
0aa6f98
to
1550652
Compare
|
Fixed it. |
Kubuxu
added
need/review
Kubuxu
force-pushed
the
feature/HiddenFilesTests
branch
from
1550652
to
a403fd8
Compare
|
|
||
| test_expect_success "ipfs add on hidden file succeeds" ' | ||
| echo "Hello Worlds!" >mountdir/.hello.txt && | ||
| ipfs add mountdir/.hello.txt >actual |
There was a problem hiding this comment.
It looks like the line above is not properly indented.
|
Otherwise this LGTM! |
whyrusleeping
added
need/author-input
It got broken no so long ago so this is the regression test for that. License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Kubuxu
force-pushed
the
feature/HiddenFilesTests
branch
from
a403fd8
to
d527e58
Compare
Kubuxu
added
RFM
and removed
need/author-input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch