use net/url to escape paths in web-ui #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Adrian Ulrich <adrian@blinkenlights.ch>
License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>
|
theres something weird here with git submodules... |
|
You're right: I forgot to remove the inner |
hackergrrl
force-pushed
the
use-net-url-escaping
branch
from
9712e75
to
8fe12ef
Compare
License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>
|
@noffle circleCI isnt super happy about that |
|
Should be good now. I had revendored by hand and didn't re-apply the unescaping change. |
License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>
|
Cool, LGTM. thanks @noffle and @adrian-bl ! |
whyrusleeping
added a commit
that referenced
this pull request
Mar 3, 2016
use net/url to escape paths in web-ui
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
use net/url to escape paths in web-ui This commit was moved from ipfs/kubo@c3204a6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is @adrian-bl's work on #2092 with his test patch added and rebased against master.
Addresses #2061.