Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

fix: manually parse the content disposition to preserve directories #42

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

Stebalien
Copy link
Member

@BigLep
Copy link

BigLep commented Sep 21, 2021

@Stebalien : thanks for doing the fix. Is there a regression test we can/should add?

@Stebalien
Copy link
Member Author

The existing tests will catch the issue when run on go 1.17 (#40).

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this does the same thing 1.17 does under the covers anyway

Ref. go1.17.1:src/mime/multipart/multipart.go;l=74-94

@lidel lidel merged commit 89dc171 into master Oct 5, 2021
@lidel lidel deleted the fix/multipart-parsing branch October 5, 2021 19:54
@lidel lidel mentioned this pull request Oct 5, 2021
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 11, 2023
fix: manually parse the content disposition to preserve directories

This commit was moved from ipfs/go-ipfs-files@89dc171
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multipart reader regression in go 1.17
3 participants